Wrap GetUserName in try-catch

Expedience.Api/Controllers/ExpedienceController.cs

@@ -58,54 +58,61 @@ namespace Expedience.Api.Controllers
         [HttpGet("UserName/{worldId}/{userHash}")]
         public async Task<ActionResult> GetUserName(int worldId, string userHash, CancellationToken cancellationToken)
         {
-            using var scope = _serviceScopeFactory.CreateScope();
+            try
-            using var dbContext = scope.ServiceProvider.GetRequiredService<ExpedienceContext>();
-
-            var lockKey = $"{worldId}-{userHash}";
-            if (_distributedLock.AcquireLock(lockKey, TimeSpan.FromSeconds(10), TimeSpan.FromMinutes(4)))
             {
-                try
+                using var scope = _serviceScopeFactory.CreateScope();
+                using var dbContext = scope.ServiceProvider.GetRequiredService<ExpedienceContext>();
+
+                var lockKey = $"{worldId}-{userHash}";
+                if (_distributedLock.AcquireLock(lockKey, TimeSpan.FromSeconds(10), TimeSpan.FromMinutes(4)))
                 {
-                    var user = dbContext.Users.FirstOrDefault(x => x.UserHash == userHash && x.WorldId == worldId);
+                    try
-                    if (user == null)
                     {
-                        string userName;
+                        var user = dbContext.Users.FirstOrDefault(x => x.UserHash == userHash && x.WorldId == worldId);
-                        var isDuplicate = false;
+                        if (user == null)
-                        do
                         {
-                            userName = UserNameGenerator.Generate();
+                            string userName;
-                            isDuplicate = dbContext.Users.Any(x => x.WorldId == worldId && x.UserName == userName);
+                            var isDuplicate = false;
-                            await Task.Delay(20, cancellationToken); // Don't hog the CPU
+                            do
-                        }
+                            {
-                        while (isDuplicate == false);
+                                userName = UserNameGenerator.Generate();
+                                isDuplicate = dbContext.Users.Any(x => x.WorldId == worldId && x.UserName == userName);
+                                await Task.Delay(20, cancellationToken); // Don't hog the CPU
+                            }
+                            while (isDuplicate == false);
 
-                        user = new User
+                            user = new User
-                        {
+                            {
-                            UserHash = userHash,
+                                UserHash = userHash,
-                            WorldId = worldId,
+                                WorldId = worldId,
-                            UserName = userName,
+                                UserName = userName,
-                            CreatedAt = DateTime.UtcNow,
+                                CreatedAt = DateTime.UtcNow,
-                        };
+                            };
 
-                        dbContext.Users.Add(user);
+                            dbContext.Users.Add(user);
-                        await dbContext.SaveChangesAsync(cancellationToken);
+                            await dbContext.SaveChangesAsync(cancellationToken);
-                    }
+                        }
 
-                    return Ok(user.UserName);
+                        return Ok(user.UserName);
 
+                    }
+                    catch (Exception ex)
+                    {
+                        _logger.LogError(ex, "Error obtaining user name for World Id {worldId} and hash {userHash}: {errorMessage}", ex.Message);
+                    }
+                    finally
+                    {
+                        _distributedLock.ReleaseLock(lockKey);
+                    }
                 }
-                catch (Exception ex)
+                else
-                {
-                    _logger.LogError(ex, "Error obtaining user name for World Id {worldId} and hash {userHash}: {errorMessage}", ex.Message);
-                }
-                finally
                 {
-                    _distributedLock.ReleaseLock(lockKey);
+                    _logger.LogError("Could not acquire lock for {lockKey}", lockKey);
                 }
             }
-            else
+            catch (Exception ex)
             {
-                _logger.LogError("Could not acquire lock for {lockKey}", lockKey);
+                _logger.LogError(ex, "Error in GetUserName: {errorMessage}", ex.Message);
             }
 
             return StatusCode(500);