Fix dumb bug

Expedience.Api/Controllers/ExpedienceController.cs

@@ -58,64 +58,55 @@ namespace Expedience.Api.Controllers
         [HttpGet("UserName/{worldId}/{userHash}")]
         public async Task<ActionResult> GetUserName(int worldId, string userHash, CancellationToken cancellationToken)
         {
-            try
+            using var scope = _serviceScopeFactory.CreateScope();
-            {
+            using var dbContext = scope.ServiceProvider.GetRequiredService<ExpedienceContext>();
-                using var scope = _serviceScopeFactory.CreateScope();
-                using var dbContext = scope.ServiceProvider.GetRequiredService<ExpedienceContext>();
 
-                var lockKey = $"{worldId}-{userHash}";
+            var lockKey = $"{worldId}-{userHash}";
-                if (_distributedLock.AcquireLock(lockKey, TimeSpan.FromSeconds(10), TimeSpan.FromMinutes(4)))
+            if (_distributedLock.AcquireLock(lockKey, TimeSpan.FromSeconds(10), TimeSpan.FromMinutes(4)))
+            {
+                try
                 {
-                    try
+                    var user = dbContext.Users.FirstOrDefault(x => x.UserHash == userHash && x.WorldId == worldId);
+                    if (user == null)
                     {
-                        var user = dbContext.Users.FirstOrDefault(x => x.UserHash == userHash && x.WorldId == worldId);
+                        string userName;
-                        if (user == null)
+                        var isDuplicate = false;
+                        do
                         {
-                            string userName;
+                            userName = UserNameGenerator.Generate();
-                            var isDuplicate = false;
+                            isDuplicate = dbContext.Users.Any(x => x.WorldId == worldId && x.UserName == userName);
-                            do
+                            await Task.Delay(20, cancellationToken); // Don't hog the CPU
-                            {
-                                userName = UserNameGenerator.Generate();
-                                isDuplicate = dbContext.Users.Any(x => x.WorldId == worldId && x.UserName == userName);
-                                await Task.Delay(20, cancellationToken); // Don't hog the CPU
-                            }
-                            while (isDuplicate == false);
-
-                            user = new User
-                            {
-                                UserHash = userHash,
-                                WorldId = worldId,
-                                UserName = userName,
-                                CreatedAt = DateTime.UtcNow,
-                            };
-
-                            dbContext.Users.Add(user);
-                            await dbContext.SaveChangesAsync(cancellationToken);
                         }
+                        while (isDuplicate == true);
 
-                        return Ok(user.UserName);
+                        user = new User
+                        {
+                            UserHash = userHash,
+                            WorldId = worldId,
+                            UserName = userName,
+                            CreatedAt = DateTime.UtcNow,
+                        };
 
+                        dbContext.Users.Add(user);
+                        await dbContext.SaveChangesAsync(cancellationToken);
                     }
-                    catch (Exception ex)
+
-                    {
+                    return Ok(user.UserName);
-                        _logger.LogError(ex, "Error obtaining user name for World Id {worldId} and hash {userHash}: {errorMessage}", ex.Message);
+
-                    }
-                    finally
-                    {
-                        _distributedLock.ReleaseLock(lockKey);
-                    }
                 }
-                else
+                catch (Exception ex)
                 {
-                    _logger.LogError("Could not acquire lock for {lockKey}", lockKey);
+                    _logger.LogError(ex, "Error obtaining user name for World Id {worldId} and hash {userHash}: {errorMessage}", ex.Message);
+                }
+                finally
+                {
+                    _distributedLock.ReleaseLock(lockKey);
                 }
             }
-            catch (Exception ex)
+            else
             {
-                _logger.LogError(ex, "Error in GetUserName: {errorMessage}", ex.Message);
+                _logger.LogError("Could not acquire lock for {lockKey}", lockKey);
             }
-
-            return StatusCode(500);
         }
     }
 }